[ 
https://issues.apache.org/jira/browse/SLING-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687809#comment-16687809
 ] 

David Bosschaert commented on SLING-8104:
-----------------------------------------

{quote}In addition your syntax above does not work in XML as a colon is 
separating namespace from the element name.
{quote}
Of course, yes. And the forward slash {{/}} is also not allowed.

Maybe the cleanest solution would be to embed the elements in group ID tags, 
like this.
{code:java}
  <artifactsOverwrites>
    <mygid><org.foo.my.bundle>1.2.3</org.foo.my.bundle></mygid> <!-- use a 
specific version -->
  </artifactsOverwrites>
{code}
Although I'm not 100% sure I can parse this in the MOJO. Another possibility 
could be to use another separator, like an underscore:
{code:java}
  <artifactsOverwrites>
    <mygid_org.foo.my.bundle>1.2.3</mygid_org.foo.my.bundle> <!-- use a 
specific version -->
  </artifactsOverwrites>
{code}

> Avoid magic when merging features
> ---------------------------------
>
>                 Key: SLING-8104
>                 URL: https://issues.apache.org/jira/browse/SLING-8104
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>            Reporter: Carsten Ziegeler
>            Assignee: David Bosschaert
>            Priority: Blocker
>             Fix For: slingfeature-maven-plugin 1.0.0, Feature Model 0.2.2
>
>
> Currently when features are merged a simple algorithm is applied which just 
> picks the highest version based on the artifact version. However this version 
> might not have no meaning at all and might not really reflect what has 
> changed inside the bundle.
> Especially when there is a major version change, this approach seems to be 
> clearly wrong
> But in the end, picking a single version is magic.
> While the problem could probably be solved by using something like a resolver 
> and figure out if just one version is enough or if both versions are needed, 
> without a resolver there is no way to figure this out.
> Therefore we should provide a similar way as we do for variables at the 
> moment: if there is a clash the caller needs to provide context on what to 
> choose.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to