+1

Carsten


Nicolas Peltier wrote
bump, we miss one vote

Le jeu. 14 févr. 2019 à 15:40, Nicolas Peltier <peltier.nico...@gmail.com>
a écrit :

fixed

Le jeu. 14 févr. 2019 à 15:35, Nicolas Peltier <peltier.nico...@gmail.com>
a écrit :

Ha, thanks, i did follow the unregular workflow for those 2 tickets: once
i did the commit, moved them in "Documentation Required", then once the
site was good, declared them as resolved, but yeah, something is left. Will
look at it, thanks for spotting this.

Le jeu. 14 févr. 2019 à 12:29, Stefan Seifert <sseif...@pro-vision.de> a
écrit :

+1

there is a strange issue with to tickets from this release:
https://issues.apache.org/jira/browse/SLING-8130
https://issues.apache.org/jira/browse/SLING-8126

both have status "Resolved" but resolution "unresolved" - this should
never happen it the JIRA workflows are configured properly. perhaps re-open
and resolving them again would fix the issue?

stefan


-----Original Message-----
From: Nicolas Peltier [mailto:peltier.nico...@gmail.com]
Sent: Tuesday, February 12, 2019 5:15 PM
To: dev@sling.apache.org
Subject: Re: [VOTE] Release Apache Sling Pipes 3.1.0

Hi

we solved 6 issues in that release:
https://issues.apache.org/jira/browse/SLING-

8126?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22pipes%203.1.0%
22

there are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING-

8194?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22pipes%203.2.0%
22

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2047/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-
release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2047 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Le mar. 12 févr. 2019 à 05:57, Nicolas Peltier <
peltier.nico...@gmail.com>
a écrit :

right, might be because of the rollback commits that got in :-/ did
experience issues with 3.1.0-SNAPSHOT-> 3.1.0 i thought i bypassed by
using
-Darguments="-Dbnd.baseline.skip=true"
one other thing that bugged me, is i had to create & export a new gpg
key
i signed the artifacts with and because of a broken computer, i could
not
properly transition them, can you confirm me signature checks for you
guys?

talking about action if signature above works, should i do a 3.1.1
release
& vote? or just resend a mail with proper message?

Le mar. 12 févr. 2019 à 04:56, Konrad Windszus <konra...@gmx.de> a
écrit
:

Sorry, didn't look closely enough.
Actually the error is fixed in bnd-baseline-maven-plugin 4.0 or newer
(was reported in https://github.com/bndtools/bnd/issues/2248 <
https://github.com/bndtools/bnd/issues/2248>).

On 12. Feb 2019, at 12:53, Konrad Windszus <konra...@gmx.de>
wrote:



2. Baselining check fails, but looks like a tooling error rather
than
an actual problem

[INFO] --- bnd-baseline-maven-plugin:3.5.0:baseline (default) @
org.apache.sling.pipes ---
[INFO] Automatically determining the baseline version for
org.apache.sling:org.apache.sling.pipes:jar:3.1.0 using repositories
[apache.releases.https (
https://repository.apache.org/service/local/staging/deploy/maven2,
default, releases+snapshots), apache.snapshots (
https://repository.apache.org/snapshots, default, snapshots),
central (
https://repo.maven.apache.org/maven2, default, releases)]
Downloading from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/maven-metadata.xml
Downloading from apache.releases.https:


https://repository.apache.org/service/local/staging/deploy/maven2/org/apach
e/sling/org.apache.sling.pipes/maven-metadata.xml
Downloading from central:


https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.pipe
s/maven-metadata.xml
Downloaded from central:


https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.pipe
s/maven-metadata.xml
(470 B at 5.1 kB/s)
Downloaded from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/maven-metadata.xml
(895 B at 761 B/s)
[WARNING] Could not transfer metadata
org.apache.sling:org.apache.sling.pipes/maven-metadata.xml from/to
apache.releases.https (
https://repository.apache.org/service/local/staging/deploy/maven2):
Failed to transfer file


https://repository.apache.org/service/local/staging/deploy/maven2/org/apach
e/sling/org.apache.sling.pipes/maven-metadata.xml
with status code 400
[INFO] The baseline version was found to be 3.1.0-SNAPSHOT
Downloading from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/3.1.0-SNAPSHOT/maven-metadata.xml
Downloading from apache.releases.https:


https://repository.apache.org/service/local/staging/deploy/maven2/org/apach
e/sling/org.apache.sling.pipes/3.1.0-SNAPSHOT/maven-metadata.xml
Downloaded from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/3.1.0-SNAPSHOT/maven-metadata.xml
(1.0 kB at 870 B/s)
[WARNING] Could not transfer metadata
org.apache.sling:org.apache.sling.pipes:3.1.0-SNAPSHOT/maven-
metadata.xml
from/to apache.releases.https (
https://repository.apache.org/service/local/staging/deploy/maven2):
Failed to transfer file


https://repository.apache.org/service/local/staging/deploy/maven2/org/apach
e/sling/org.apache.sling.pipes/3.1.0-SNAPSHOT/maven-metadata.xml
with status code 400
Downloading from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/3.1.0-SNAPSHOT/org.apache.sling.pipes-3.1.0-20190212.095516-22.jar
Downloaded from apache.snapshots:


https://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.p
ipes/3.1.0-SNAPSHOT/org.apache.sling.pipes-3.1.0-20190212.095516-22.jar
(152 kB at 97 kB/s)
[ERROR] The bundle version change (3.1.0 to 3.1.0) is too low, the
new
version must be at least 3.1.1
[INFO]

------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Sling Pipes 3.1.0 ...........................
FAILURE [
24.637 s]
[INFO] Apache Sling Staging Repository 2047 1.0.0 .........
SKIPPED
[INFO]

------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]

------------------------------------------------------------------------
[INFO] Total time:  24.832 s
[INFO] Finished at: 2019-02-12T12:40:21+01:00
[INFO]

------------------------------------------------------------------------
[ERROR] Failed to execute goal
biz.aQute.bnd:bnd-baseline-maven-plugin:3.5.0:baseline (default) on
project
org.apache.sling.pipes: An error occurred while calculating the
baseline:
The baselining plugin detected versioning errors -> [Help 1]
[ERROR]

This is not a tooling error, but rather how Semantic Versioning is
supposed to be (compare with
https://github.com/bndtools/bnd/issues/2859
<https://github.com/bndtools/bnd/issues/2859>).
It seems though that this was not enforced by the baselining goal
in
maven-bundle-plugin for some reason.
https://www.osgi.org/wp-content/uploads/SemanticVersioning.pdf
states

Requiring another bundle is similar to a short form of importing
all
the exported packages of that required bundle. The version of a
bundle
must
therefore semantically aggregate the semantics of all its constituent
packages. If any of these packages is incompatible with its providers
then
the bundle version must increment the minor version. If any of these
packages is incompatible with consumers, the bundle version must
increment
the major version. It is clear, that on average, the version of a
bundle
will be much more volatile than the versions of its constituent
packages,
increasing the dependency problems.






--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Reply via email to