stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288084260
##########
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##########
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+ public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
+ List<MockRequestParameter> list =
Arrays.asList(this.parameterMap.get(name));
Review comment:
this code is redundant across all three methods of addRequestParameter -
maybe put it in one helper method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
