npeltier commented on a change in pull request #10: SLING-8648
URL:
https://github.com/apache/sling-org-apache-sling-pipes/pull/10#discussion_r316579841
##########
File path: src/main/java/org/apache/sling/pipes/internal/MovePipe.java
##########
@@ -63,23 +67,38 @@ public boolean modifiesContent() {
try {
Session session = resolver.adaptTo(Session.class);
if (session.itemExists(targetPath)){
- if (overwriteTarget && !isDryRun()) {
- logger.debug("overwriting {}", targetPath);
+ if (overwriteTarget || orderBefore && !isDryRun()) {
Review comment:
i'd clarify the test here with a set of parenthesis around `overwriteTarget
|| orderBefore`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
