Interesting thought - I didn't think about using [1].
I think it is fine though, since those two bundles should
never be referenced via maven directly - rather they are
part of a runtime (as e.g. compiled by the provisioning
model [2] or the feature model). For those non-pom
references, I don't think the metadata from [1] would
be picked up.
I included a different mechanism though: By explicitly
referencing the new Felix HC API [3] the new bundles only
start if the Felix API bundle is installed - so anybody
blindly upgrading to apache-sling-hc-core|webconsole
2.0.0 will get unstarted bundles showing the missing
Felix HC API package - that should be pointer enough to
find the migration guide [4].
-Georg
[1] https://maven.apache.org/guides/mini/guide-relocation.html
[2]
https://github.com/apache/sling-org-apache-sling-starter/blob/master/src/main/provisioning/healthcheck.txt
[3]
https://github.com/apache/sling-org-apache-sling-hc-core/blob/b0cfe3c8f7fdc1790f8c16bc075967f12ce33686/src/main/java/org/apache/sling/hc/core/impl/NoopHcCore.java#L33
[4]
https://sling.apache.org/documentation/bundles/sling-health-check-tool.html
On 2019-08-26 10:04, Konrad Windszus wrote:
Yes, Felix HC. This is a drop in replacement at least for these two
bundles IMHO (although the API package has changed).
Konrad
On 26. Aug 2019, at 10:01, Stefan Seifert <[email protected]>
wrote:
relocate to what - felix HC?
relocate makes only sense if the new target is a drop-in replacement -
which is not the case with sling HC -> felix HC?
stefan
-----Original Message-----
From: Konrad Windszus [mailto:[email protected]]
Sent: Monday, August 26, 2019 9:51 AM
To: [email protected]
Subject: Re: [VOTE] Release Apache Sling Health Check Core 2.0.0,
Sling
Health Check Web Console 2.0.0
Hi Georg,
wouldn't it make sense to add a relocation section to this last
release
(https://maven.apache.org/guides/mini/guide-relocation.html
<https://maven.apache.org/guides/mini/guide-relocation.html>)?
That way it would be even more obvious on how to migrate...
Konrad
On 22. Aug 2019, at 19:34, Georg Henzler <[email protected]>
wrote:
Hi,
We solved 1 issues in this release:
https://issues.apache.org/jira/browse/SLING-8653
There are no outstanding issues.
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2117/
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-
release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2117 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
-Georg
