[ 
https://issues.apache.org/jira/browse/SLING-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933496#comment-16933496
 ] 

Robert Munteanu commented on SLING-8602:
----------------------------------------

[~angela] - I think your patches need rebasing, can you please submit new ones 
or create updated pull requests? Thanks!

Also, feel free to paste the documentation updates here or send a patch/PR for 
https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/bundles/repository-initialization.md
 .

{noformat}$ patch -p0 < SLING-8602-parser.patch 
patching file 
src/main/java/org/apache/sling/repoinit/parser/operations/package-info.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file 
src/main/java/org/apache/sling/repoinit/parser/operations/package-info.java.rej
patching file 
src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java
patching file src/test/resources/testcases/test-33.txt
patching file 
src/main/java/org/apache/sling/repoinit/parser/operations/AclLine.java
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file 
src/main/java/org/apache/sling/repoinit/parser/operations/AclLine.java.rej
patching file src/main/javacc/RepoInitGrammar.jjt
Hunk #2 FAILED at 95.
Hunk #3 succeeded at 133 (offset 1 line).
Hunk #4 FAILED at 219.
Hunk #5 succeeded at 472 (offset 1 line).
2 out of 5 hunks FAILED -- saving rejects to file 
src/main/javacc/RepoInitGrammar.jjt.rej
patching file 
src/main/java/org/apache/sling/repoinit/parser/operations/OperationVisitor.java
patching file src/test/resources/testcases/test-33-output.txt
patching file 
src/test/java/org/apache/sling/repoinit/parser/test/OperationToStringVisitor.java

$ patch -p0 < SLING-8602-jcr.patch 
patching file 
src/test/java/org/apache/sling/jcr/repoinit/PrincipalBasedAclTest.java
patching file src/main/java/org/apache/sling/jcr/repoinit/impl/AclVisitor.java
patching file src/test/java/org/apache/sling/jcr/repoinit/impl/TestUtil.java
patching file 
src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java
patching file pom.xml
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file pom.xml.rej
patching file src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 120.
Hunk #4 succeeded at 156 (offset -3 lines).
Hunk #5 succeeded at 229 with fuzz 1 (offset 3 lines).
2 out of 5 hunks FAILED -- saving rejects to file 
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java.rej
{noformat}

> Add support for PrincipalAccessControlList and ac-management by principal
> -------------------------------------------------------------------------
>
>                 Key: SLING-8602
>                 URL: https://issues.apache.org/jira/browse/SLING-8602
>             Project: Sling
>          Issue Type: New Feature
>          Components: Repoinit
>            Reporter: angela
>            Assignee: Robert Munteanu
>            Priority: Major
>              Labels: Sling-12-ReleaseNotes
>             Fix For: Repoinit Parser 1.2.8, Repoinit JCR 1.1.14
>
>         Attachments: SLING-8602-jcr.patch, SLING-8602-parser.patch
>
>
> with JCR-4429 comes a new type of {{JackrabbitAccessControlList}} that allows 
> to provide native support for access control management by principal as 
> defined by 
> {{org.apache.jackrabbit.api.security.JackrabbitAccessControlManager}}.  
> now that there exists a new authorization model in Oak (OAK-8190) that 
> implements these extensions, it would be desirable if the repo-init would 
> cover access control management by principal.
> note: while the original aim of OAK-8190 was to store permissions for system 
> users (aka service users) separately, the implementation in 
> _oak-authorization-principalbased_ is not limited to system users and doesn't 
> mandate the policies to be stored with a user node. the location of the 
> access controlled node is an implementation detail that can be changed. see 
> Jackrabbit API and 
> http://jackrabbit.apache.org/oak/docs/security/authorization/principalbased.html
>  for additional details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to