klcodanr commented on a change in pull request #46: SlingModelPersistor:
Improvements for compatibility and additional Ignore features, several bug fixes
URL: https://github.com/apache/sling-whiteboard/pull/46#discussion_r330151780
##########
File path: SlingModelPersist/pom.xml
##########
@@ -172,6 +172,17 @@
<artifactId>maven-bundle-plugin</artifactId>
<version>4.2.0</version>
<extensions>true</extensions>
+ <configuration>
+ <instructions>
+
<Export-Package>org.apache.sling.models.injectors,org.apache.sling.models.persistor,org.apache.sling.models.persistor.annotations</Export-Package>
+
<Private-Package>org.apache.sling.models.injectors.*,org.apache.sling.models.persist.*,org.apache.sling.models.persistor.*</Private-Package>
Review comment:
@badvision - Why is setting the Private Packages explicitly here necessary?
Shouldn't you be able to follow the standard packaging naming conventions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
