rombert commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-552389808 My reading of the code is that it's not null-safe anyway. It will fail at `o1 == 0` and `o2 == 0`. Incidentally, the original code was safe when comparing two nulls but fails now. I don't think that was intended though. I would suggest to use whichever you prefer of `Integer.compare` or `Integer.compareTo`, I don't think it makes a great difference. /cc @bosschaert
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
