bosschaert commented on a change in pull request #3: SLING-9007: Base the
region calculation on the feature-origin and add…
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/3#discussion_r367480651
##########
File path:
src/test/java/org/apache/sling/feature/extension/apiregions/APIRegionMergeHandlerTest.java
##########
@@ -144,103 +146,15 @@ public void testRegionExportsNoInheritance() throws
Exception {
Extension tgEx = tf.getExtensions().iterator().next();
- String expectedJSON =
"[{\"name\":\"global\",\"exports\":[\"a.b.c\",\"d.e.f\"]},"
- + "{\"name\":\"deprecated\",\"exports\":[\"klm\",\"qrs\"]},"
- + "{\"name\":\"internal\",\"exports\":[\"xyz\"]},"
- + "{\"name\":\"forbidden\",\"exports\":[\"abc\",\"klm\"]}]";
+ String expectedJSON =
"[{\"name\":\"global\",\"exports\":[\"a.b.c\",\"d.e.f\"],\"feature-origins\":\"y:s:2\"},"
Review comment:
should `feature-origins` not be a JSON Array?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
