cziegeler commented on a change in pull request #15: Feature/sling 7768: String Interpolation for ETC Map URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/15#discussion_r369950715
########## File path: src/main/java/org/apache/sling/resourceresolver/impl/mapping/Interpolator.java ########## @@ -0,0 +1,154 @@ +/* Review comment: It's ok to have a copy here for getting the functionality in, but we should rather directly use the class from Apache Felix by embedding just that class (and using the maven shade plugin to move it to a different package). But we can do this in a follow up commit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
