[ 
https://issues.apache.org/jira/browse/SLING-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051861#comment-17051861
 ] 

Konrad Windszus edited comment on SLING-9167 at 3/5/20, 7:48 AM:
-----------------------------------------------------------------

bnd only allows to automatically embed full packages (by inspecting the code). 
With single classes one has to manually check that this single class does not 
have any other required dependencies. In this case I appreciate embedding too 
many classes over the manual effort (and risk) to identify all necessary 
classes. 
Is there any concrete issues with that apart from the slightly increased size 
of the bundle?


was (Author: kwin):
bnd only allows to automatically embed full packages (by inspecting the code(. 
With single classes one has to manually check that this single class does not 
have any other required dependencies. In this case I appreciate embedding too 
many classes over the manual effort (and risk) to identify all necessary 
classes.

> Installer core embeds too many config admin classes
> ---------------------------------------------------
>
>                 Key: SLING-9167
>                 URL: https://issues.apache.org/jira/browse/SLING-9167
>             Project: Sling
>          Issue Type: Bug
>          Components: Installer
>    Affects Versions: Installer Core 3.10.0, Installer Core 3.10.2
>            Reporter: Carsten Ziegeler
>            Priority: Major
>             Fix For: Installer Core 3.10.4
>
>
> It seems complete packages from Apache Felix CM are now included, previously 
> these were only single classes:
>  
> org.apache.felix.configadmin;inline="org/apache/felix/cm/file/ConfigurationHandler.*",
> vs
> org/apache/felix/cm/NotCachablePersistenceManager.class
> org/apache/felix/cm/PersistenceManager.class
> org/apache/felix/cm/file/ConfigurationHandler.class
> org/apache/felix/cm/file/FilePersistenceManager$1.class
> org/apache/felix/cm/file/FilePersistenceManager$2.class
> org/apache/felix/cm/file/FilePersistenceManager$3.class
> org/apache/felix/cm/file/FilePersistenceManager$4.class
> org/apache/felix/cm/file/FilePersistenceManager$DictionaryEnumeration$1.class
> org/apache/felix/cm/file/FilePersistenceManager$DictionaryEnumeration.class
> org/apache/felix/cm/file/FilePersistenceManager.class
> org/apache/felix/cm/file/package-info.class
> org/apache/felix/cm/package-info.class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to