DominikSuess commented on a change in pull request #6: SLING-9172 - adding
support for property sling.installer.multiversion…
URL:
https://github.com/apache/sling-org-apache-sling-installer-core/pull/6#discussion_r388288680
##########
File path:
src/main/java/org/apache/sling/installer/core/impl/tasks/BundleTaskCreator.java
##########
@@ -71,14 +71,17 @@
private BundleBlackList bundleBlacklist;
+ private boolean isMultiVersion;
+
/**
* @see
org.apache.sling.installer.core.impl.InternalService#init(org.osgi.framework.BundleContext,
org.apache.sling.installer.api.ResourceChangeListener, RetryHandler)
*/
@Override
public void init(final BundleContext bc, final ResourceChangeListener
listener, final RetryHandler retryHandler) {
this.bundleContext = bc;
this.retryHandler = retryHandler;
-
+
+ this.isMultiVersion =
Boolean.valueOf(bc.getProperty("sling.installer.multiversion")) ? true : false;
Review comment:
@kwin there is no need to elaborate on the concrete scenarios faced - but
the basic is pretty simple: as soon as you have more than one version of the
same bsn in the game (a scenario that the feature launcher and felix support)
the statehandling falls appart and you eventually end up with ignored resources
where you can't recover the installer state without starting over from scratch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
