YegorKozlov opened a new pull request #15: use Set instead of a List to test ignoreUrlParams URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15 In our setup we have a list of ignored GET parameters (_include-filter.config.ignoreUrlParams_) which grew with time to a hundred or so elements . _org.apache.sling.dynamicinclude.Configuration_ loads these into a _java.util.List_ which is further checked from IncludeTagFilter via _List#contains_ Calling _List#contains_ in a loop is kind of a smell. I believe _java.util.Set_ will be a more appropriate containter with fixed O(1) cost of _contains()_.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
