[
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066011#comment-17066011
]
Nitin Gupta edited comment on SLING-9171 at 3/24/20, 5:31 PM:
--------------------------------------------------------------
Thanks [~bdelacretaz], agree that moving the parsing logic to PropertyLine
helps in debugging and also simplifying the regex. Moreover, this has also
enabled type validation for other types of values.
i was just wondering if we could use _javax.jcr.Value_ instead of _Object_ in
_PropertyLine#getValues_ API to make the API more restrictive, but i guess, we
would want to keep the APIs for repoinit parser independent of jcr in general,
and that's why Object is more appropriate.
That being said, I'm all good with the changes. Thanks again for reviewing and
improving this.
was (Author: nitigupt):
Thanks [~bdelacretaz], agree that moving the parsing logic to PropertyLine
helps is debugging and also simplifying the regex. Moreover, this has also
enabled type validation for other types of values.
i was just wondering if we could use _javax.jcr.Value_ instead of _Object_ in
_PropertyLine#getValues_ API to make the API more restrictive, but i guess, we
would want to keep the APIs for repoinit parser independent of jcr in general,
and that's why Object is more appropriate.
That being said, I'm all good with the changes. Thanks again for reviewing and
improving this.
> Support for settings properties on paths created via repoinit create path
> -------------------------------------------------------------------------
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Reporter: Nitin Gupta
> Assignee: Bertrand Delacretaz
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom
> properties to the nodes valuemap via repoinit. This is a gap currently.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
