[ 
https://issues.apache.org/jira/browse/SLING-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohit Arora updated SLING-9332:
-------------------------------
    Description: 
The [error message logged 
in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
  SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
seems to have stopped processing the object arrays for log statements. Because 
of this the error logged in case of unsuccessful distribution looks like - 

{noformat}06.04.2020 07:48:30.411 *ERROR* 
[sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
 org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor 
could not deliver package 
[dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
queue-bpdistributionagent0] from queue {}
org.apache.sling.distribution.common.DistributionException: 
org.apache.http.client.HttpResponseException: Bad Gateway
        at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
 [org.apache.sling.commons.scheduler:2.7.6]
        at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
[org.apache.sling.commons.scheduler:2.7.6]
        at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
        at 
org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
 [org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
[org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
[org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
 [org.apache.sling.distribution.core:0.4.2]
        ... 9 common frames omitted{noformat}

  was:
The[ error message logged 
in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
  SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
seems to have stopped processing the object arrays for log statements. Because 
of this the error logged in case of unsuccessful distribution looks like - 

{noformat}06.04.2020 07:48:30.411 *ERROR* 
[sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
 org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor 
could not deliver package 
[dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
queue-bpdistributionagent0] from queue {}
org.apache.sling.distribution.common.DistributionException: 
org.apache.http.client.HttpResponseException: Bad Gateway
        at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
 [org.apache.sling.distribution.core:0.4.2]
        at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
 [org.apache.sling.commons.scheduler:2.7.6]
        at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
[org.apache.sling.commons.scheduler:2.7.6]
        at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
        at 
org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
 [org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
[org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
[org.apache.httpcomponents.httpclient:4.5.4]
        at 
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
 [org.apache.sling.distribution.core:0.4.2]
        ... 9 common frames omitted{noformat}


> Error logged for NonRecoverableDistributionException in 
> SimpleDistributionAgentQueueProcessor does not log queuename
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-9332
>                 URL: https://issues.apache.org/jira/browse/SLING-9332
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>            Reporter: Mohit Arora
>            Priority: Minor
>             Fix For: Content Distribution Core 0.4.4
>
>
> The [error message logged 
> in|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L157]
>   SimpleDistributionAgentQueueProcessor uses an _Object_ to log 
> distributionpackage ID and queuename. However, from version 1.7 onward, log4j 
> seems to have stopped processing the object arrays for log statements. 
> Because of this the error logged in case of unsuccessful distribution looks 
> like - 
> {noformat}06.04.2020 07:48:30.411 *ERROR* 
> [sling-default-1-resource-queueProcessor-bpdistributionagent0-queue-bpdistributionagent0]
>  
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor
>  could not deliver package 
> [dstrpck-1586159284848-e4c369fc-5bbf-4cfc-9ea3-2819af650784, 
> queue-bpdistributionagent0] from queue {}
> org.apache.sling.distribution.common.DistributionException: 
> org.apache.http.client.HttpResponseException: Bad Gateway
>       at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:162)
>  [org.apache.sling.distribution.core:0.4.2]
>       at 
> org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:66)
>  [org.apache.sling.distribution.core:0.4.2]
>       at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.processQueueItem(SimpleDistributionAgentQueueProcessor.java:134)
>  [org.apache.sling.distribution.core:0.4.2]
>       at 
> org.apache.sling.distribution.agent.impl.SimpleDistributionAgentQueueProcessor.process(SimpleDistributionAgentQueueProcessor.java:91)
>  [org.apache.sling.distribution.core:0.4.2]
>       at 
> org.apache.sling.distribution.queue.impl.simple.SimpleDistributionQueueProcessor.run(SimpleDistributionQueueProcessor.java:53)
>  [org.apache.sling.distribution.core:0.4.2]
>       at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.6]
>       at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.6]
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.http.client.HttpResponseException: Bad Gateway
>       at 
> org.apache.http.impl.client.AbstractResponseHandler.handleResponse(AbstractResponseHandler.java:70)
>  [org.apache.httpcomponents.httpclient:4.5.4]
>       at 
> org.apache.http.client.fluent.Response.handleResponse(Response.java:90) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>       at 
> org.apache.http.client.fluent.Response.returnContent(Response.java:97) 
> [org.apache.httpcomponents.httpclient:4.5.4]
>       at 
> org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:148)
>  [org.apache.sling.distribution.core:0.4.2]
>       ... 9 common frames omitted{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to