cmrockwell edited a comment on issue #51: SAML2 Service Provider Pull Request URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-612043203 Having a built-in IDP during development was really useful and simplified the setup and testing. I get the point is that there should be another way to test the SP code without the demo IDP. I'm curious whether you tried to test it with the internal IDP. This would be the simplest way. I thought the mock IDP might potentially help in troubleshooting issues, which is why I considered an enable/disable switch for it. Nevertheless, the internal IDP and Saml2ExternalIdentityProvider can be removed from the PR. It wont work without Saml2LoginModule as it stands today, but let me know what code changes would allow it to work without a login module. I will keep the internal IDP on a dev branch, because it is so handy. But otherwise could remove some code from the PR. At the same time I still need to add code for a few features. 1. User attribute synchronization: allows setting of user properties like email, given and family names, address, etc based on the data contained in the Assertion. 2. SP metadata provider servlet: this should simply IDP configuration since most IDP's allow SP's to be registered by inputing the metadata. Without this admins might need to craft the data by hand There is going to be some code to review because there's a lot involved with implementing a SAML2 Service Provider authentication handler. Do you have a target number for LOC?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
