[GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on a change in pull request #40: SLING-9212 Distribution code checks for jcr:removeNode permissions on importer side for DELETE request

[GitBox]

actinium15 commented on a change in pull request #40:
URL: 
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/40#discussion_r413640919



##########
File path: 
src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java
##########
@@ -37,12 +39,18 @@
 
     private final String jcrPrivilege;
 
-    public PrivilegeDistributionRequestAuthorizationStrategy(String 
jcrPrivilege) {
+    private String[] additionalJcrPrivilegesForAdd;

Review comment:
       ```suggestion
       private final String[] additionalJcrPrivilegesForAdd;
   ```

##########
File path: 
src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java
##########
@@ -105,5 +113,14 @@ private String getClosestParent(Session session, String 
path) throws RepositoryE
         return null;
     }
 
+    private static Privilege[] computePrivileges(AccessControlManager acMgr, 
String[] jcrPrivileges, String jcrPrivilege)

Review comment:
       ```suggestion
       private static Privilege[] computePrivileges(AccessControlManager acMgr, 
String jcrPrivilege, String[] additionalJcrPrivileges)
   ```

##########
File path: 
src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java
##########
@@ -37,12 +39,18 @@
 
     private final String jcrPrivilege;
 
-    public PrivilegeDistributionRequestAuthorizationStrategy(String 
jcrPrivilege) {
+    private String[] additionalJcrPrivilegesForAdd;
+
+    private String[] additionalJcrPrivilegesForDelete;

Review comment:
       ```suggestion
       private final String[] additionalJcrPrivilegesForDelete;
   ```

##########
File path: 
src/main/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategy.java
##########
@@ -105,5 +113,14 @@ private String getClosestParent(Session session, String 
path) throws RepositoryE
         return null;
     }
 
+    private static Privilege[] computePrivileges(AccessControlManager acMgr, 
String[] jcrPrivileges, String jcrPrivilege)
+            throws RepositoryException {
+        ArrayList<Privilege> privileges = new ArrayList<Privilege>();
+        privileges.add(acMgr.privilegeFromName(jcrPrivilege));
+        for (String privilege : jcrPrivileges) {

Review comment:
       ```suggestion
           for (String privilege : additionalJcrPrivileges) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org