mohiaror commented on a change in pull request #40:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/40#discussion_r415394182
##########
File path:
src/test/java/org/apache/sling/distribution/agent/impl/PrivilegeDistributionRequestAuthorizationStrategyTest.java
##########
@@ -131,23 +175,53 @@ public void testNoPermissionOnDelete() throws Exception {
}
@Test
- public void testPermissionOnDelete() throws Exception {
+ public void testDefaultPermissionOnDelete() throws Exception {
String jcrPrivilege = "somePermission";
- PrivilegeDistributionRequestAuthorizationStrategy strategy = new
PrivilegeDistributionRequestAuthorizationStrategy(jcrPrivilege);
+ String DEFAULT_DELETE_PRIVELEGE = "jcr:removeNode";
Review comment:
Using Privilege.JCR_REMOVE_NODE will give it an expanded form which will
not look good on the config manager UI and might confuse the admin that this is
the way the privileges are supposed to be configured.
I will take care of the typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
