kwin commented on a change in pull request #8:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#discussion_r420686584
##########
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java
##########
@@ -33,6 +33,7 @@
import javax.jcr.Property;
import javax.jcr.RepositoryException;
import javax.jcr.Value;
+import org.apache.jackrabbit.JcrConstants;
Review comment:
Please use the constants from
https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/constant-values.html
instead and remover the static imports for org.apache.jackrabbit.JcrConstants
as well.
##########
File path:
src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResourceMetadata.java
##########
@@ -35,6 +35,8 @@
import javax.jcr.Property;
import javax.jcr.RepositoryException;
import javax.jcr.ValueFormatException;
+import org.apache.jackrabbit.JcrConstants;
+import static org.apache.jackrabbit.JcrConstants.NT_FILE;
Review comment:
Please clean up imports and only use constants from
https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/constant-values.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
