cziegeler commented on a change in pull request #54:
URL:
https://github.com/apache/sling-slingfeature-maven-plugin/pull/54#discussion_r429812492
##########
File path: src/main/java/org/apache/sling/feature/maven/mojos/ApisJarMojo.java
##########
@@ -1582,6 +1589,14 @@ private File createArchive(final ApisJarContext ctx,
archiveConfiguration.addManifestEntry("Specification-Vendor",
project.getOrganization().getName());
}
+ // replace manifest entries with the one provided in properties
configuration
+ Map<String,String> archiveConfigMap =
archiveConfiguration.getManifestEntries();
+ for (final String name: manifestProperties.stringPropertyNames()){
+ if(archiveConfigMap.containsKey(name))
Review comment:
ok, yes, I think it makes sense to allow adding additional key/value
pairs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
