[
https://issues.apache.org/jira/browse/SLING-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138121#comment-17138121
]
Travis Estell commented on SLING-7731:
--------------------------------------
This bug is causing a major performance problem with my team's production
application, because both modifiedService() and addService() get called on
every modification event.
I have submitted a pull request here:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3
> Call to addService is no longer needed for modification events in
> SlingAuthenticatorServiceListener
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-7731
> URL: https://issues.apache.org/jira/browse/SLING-7731
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.3.18
> Reporter: Vincent Frey
> Priority: Major
>
> After introduction of modifiedService(...) method in
> SlingAuthenticatorServiceListener, calling addService(...) is no longer
> needed for modification event.
> [https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L85]
> Therefore line 85 should be changed from:
> {code}
> if ((event.getType() & (ServiceEvent.REGISTERED | ServiceEvent.MODIFIED)) !=
> 0) {
> {code}
> to:
> {code}
> if ((event.getType() & ServiceEvent.REGISTERED) != 0) {
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
