GastonGonzalez commented on pull request #48: URL: https://github.com/apache/sling-site/pull/48#issuecomment-645505183
> Thank you for this great contribution! I like the howto pages a lot (in general - haven't checked all the details but they can evolve anyway), with just a few tweaks: > > * The tag should be "featuremodel" as a "feature model" link won't work from the tag pages links like at https://sling.apache.org/tags/development.html > * I think feature-model-overview.md should rather be named feature-model-howto.md as that is really what it's about. > > Like Carsten I think documentation/development/feature-model.md overlaps with the existing https://github.com/apache/sling-org-apache-sling-feature > > I would prefer expanding that README so we end up with: > > * The how-to pages on the website > * The reference documentation in Git repositories as is now > * https://sling.apache.org/documentation/development/feature-model.html as the "module discovery page" as now. We can add links to the howto main page + maybe to all the related repositories using [this query](https://github.com/search?q=topic%3Asling+topic%3Aosgi-feature-model+topic%3Aosgi+org%3Aapache&type=Repositories) and adding GitHub Topics to those repositories (which I did already). But the additional information should go to the existing README to avoid duplication. > > Would that work? This works. Updates committed. Thanks for the review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org