[ 
https://issues.apache.org/jira/browse/SLING-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147605#comment-17147605
 ] 

Amit Jain commented on SLING-9472:
----------------------------------

[~cschneider] It seems to me the PR failing just becuase of the insufficient 
code coverage (< 80%). See [1] and the details of the coverage for classes [2]. 
All tests seem to be passing [3]

[1] 
[https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/45/checks?check_run_id=814139711]

[2] 
[https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal&pullRequest=45&metric=new_coverage&view=list]

[3] 
[https://builds.apache.org/blue/organizations/jenkins/Sling%2Fsling-org-apache-sling-distribution-journal/detail/PR-45/6/tests]

> Make Precondition return immediately
> ------------------------------------
>
>                 Key: SLING-9472
>                 URL: https://issues.apache.org/jira/browse/SLING-9472
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>    Affects Versions: Content Distribution Journal Core 0.1.16
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>            Priority: Major
>             Fix For: Content Distribution Journal Core 0.1.18
>
>
> For the content distribution service we have to split our 
> distribution.journal code into one part that is sling facing and another that 
> is journal facing.
> One first step is to simplify the  Precondition to return a Decision 
> immediately.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to