Hi Julian,

In reviewing the history, it looks like the dependency on oak-core was
first introduced to resolve SLING-7886 and SLING-7887 via the commit at
[3].  If I recall correctly, that 1.6.x version of oak was the version that
was being used in the sling starter (version 10'ish) at the time so I chose
that as the minimum version to depend on.  As far as I can tell, the code
being utilized here is still compatible with the latest version of oak so
there hasn't been any reason to change the minimum version yet.

I suppose we could now change that dependency
to org.apache.jackrabbit:oak-security-spi instead as long as everyone is
comfortable with moving the minimum version of oak up to version 1.8 or
later?

1. https://issues.apache.org/jira/browse/SLING-7886
2. https://issues.apache.org/jira/browse/SLING-7887
3.
https://github.com/apache/sling-org-apache-sling-jcr-jackrabbit-usermanager/commit/141637a6afaae62f593eb45ab4721b5b356e3182#diff-ad9077962ed0c1d4663683f490b1a073

Regards,
-Eric

On Mon, Jul 27, 2020 at 3:25 AM Julian Reschke <julian.resc...@gmx.de>
wrote:

> Am 26.07.2020 um 23:39 schrieb Eric Norman:
> > Hi,
> >
> > We solved 3 issues in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12344081
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2304/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2304 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >    [ ] +1 Approve the release
> >    [ ]  0 Don't care
> >    [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
>
> Out of curiosity: why does this have a dependency on oak-*core*, and
> that at a very very outdated version?
>
> Best regards, Julian
>
>

Reply via email to