kwin commented on a change in pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r477295346
##########
File path: pom.xml
##########
@@ -43,120 +42,120 @@
<build>
<plugins>
-
+ <!-- Maven Sling Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.sling</groupId>
+ <artifactId>sling-maven-plugin</artifactId>
</plugin>
-
+ <!-- BND Maven Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
- <configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
- </configuration>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
</plugin>
-
<plugin>
- <groupId>org.apache.sling</groupId>
- <artifactId>maven-sling-plugin</artifactId>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-baseline-maven-plugin</artifactId>
</plugin>
-
</plugins>
</build>
<dependencies>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
- <version>2.2.0</version>
+ <version>2.18.4</version>
Review comment:
Why do you require new runtime dependencies (api, commons osgi, ...)?
##########
File path: bnd.bnd
##########
@@ -0,0 +1,17 @@
+Bundle-Category: sling
Review comment:
Please don't duplicate meta information already set in parent
##########
File path: pom.xml
##########
@@ -43,120 +42,120 @@
<build>
<plugins>
-
+ <!-- Maven Sling Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-scr-plugin</artifactId>
+ <groupId>org.apache.sling</groupId>
+ <artifactId>sling-maven-plugin</artifactId>
</plugin>
-
+ <!-- BND Maven Plugin -->
<plugin>
- <groupId>org.apache.felix</groupId>
- <artifactId>maven-bundle-plugin</artifactId>
- <extensions>true</extensions>
- <configuration>
- <instructions>
-
<Export-Package>org.apache.sling.superimposing</Export-Package>
-
<Private-Package>org.apache.sling.superimposing.impl</Private-Package>
-
<DynamicImport-Package>org.apache.felix.webconsole</DynamicImport-Package>
-
<Sling-Nodetypes>SLING-INF/nodetypes/superimposing.cnd</Sling-Nodetypes>
- </instructions>
- </configuration>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-maven-plugin</artifactId>
</plugin>
-
<plugin>
- <groupId>org.apache.sling</groupId>
- <artifactId>maven-sling-plugin</artifactId>
+ <groupId>biz.aQute.bnd</groupId>
+ <artifactId>bnd-baseline-maven-plugin</artifactId>
</plugin>
-
</plugins>
</build>
<dependencies>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.api</artifactId>
- <version>2.2.0</version>
+ <version>2.18.4</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.commons.osgi</artifactId>
- <version>2.1.0</version>
+ <version>2.4.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.settings</artifactId>
- <version>1.0.0</version>
+ <version>1.3.8</version>
<scope>provided</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.apache.sling</groupId>
+
<artifactId>org.apache.sling.serviceusermapper</artifactId>
+ <version>1.3.6</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.6</version>
+ </dependency>
<dependency>
- <groupId>commons-lang</groupId>
- <artifactId>commons-lang</artifactId>
- <version>2.4</version>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-collections4</artifactId>
+ <version>4.1</version>
+ </dependency>
+ <!-- OSGi Dependencies -->
+ <dependency>
+ <groupId>org.osgi</groupId>
+
<artifactId>org.osgi.service.component.annotations</artifactId>
<scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>commons-collections</groupId>
- <artifactId>commons-collections</artifactId>
- <version>3.1</version>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+
<artifactId>org.osgi.service.metatype.annotations</artifactId>
+ <version>1.4.0</version>
Review comment:
Don't set versions for dependencies managed in parent
##########
File path: pom.xml
##########
@@ -19,14 +19,13 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.sling</groupId>
- <artifactId>sling</artifactId>
- <version>26</version>
- <relativePath/>
+ <artifactId>sling-bundle-parent</artifactId>
+ <version>38</version>
Review comment:
Please use most recent version (39)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
