cziegeler commented on a change in pull request #31:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505388455



##########
File path: 
src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##########
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid, 
Dictionary<String, Obje
         }
     }
 
+    private void addAPIRegions(Feature feature, List<String> exportedPackages) 
{

Review comment:
       The regions java api supports generating (and parsing) of the extension 
JSON - we should not do this by hand anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to