[ https://issues.apache.org/jira/browse/SLING-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konrad Windszus updated SLING-9858: ----------------------------------- Description: Given that there are better alternatives for most packages in Commons Testing (https://issues.apache.org/jira/browse/SLING-7166) we should get rid of the dependency in Models Impl. As only a mock for SlingHttpServletRequest is used from commons testing AFAICS we should start using https://github.com/apache/sling-org-apache-sling-servlet-helpers/blob/master/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java instead. was:Given that there are better alternatives for most packages in Commons Testing (https://issues.apache.org/jira/browse/SLING-7166) we should get rid of the dependency in Models Impl. > Get rid of commons testing dependency > ------------------------------------- > > Key: SLING-9858 > URL: https://issues.apache.org/jira/browse/SLING-9858 > Project: Sling > Issue Type: Improvement > Components: Sling Models > Affects Versions: Models Implementation 1.4.16 > Reporter: Konrad Windszus > Priority: Major > Fix For: Models Implementation 1.4.18 > > > Given that there are better alternatives for most packages in Commons Testing > (https://issues.apache.org/jira/browse/SLING-7166) we should get rid of the > dependency in Models Impl. > As only a mock for SlingHttpServletRequest is used from commons testing > AFAICS we should start using > https://github.com/apache/sling-org-apache-sling-servlet-helpers/blob/master/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java > instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)