[ 
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227635#comment-17227635
 ] 

Henry Kuijpers commented on SLING-2938:
---------------------------------------

I like what you have some with regards to combining the IT with the actual 
production code, [~bdelacretaz]! I completely agree that the 2 should be tied 
together, as of course they strictly depend on each other. Currently on my 
mobile phone, so I'll try to have a look tomorrow on my laptop as well. As long 
as the tests run properly, then here's already my +1. 

The reason I put them in a separate repository, is because that was more in 
line with the sling servlet annotations tests. So we might consider doing the 
same thing over there as well then. 

I'm also very glad that the Sling starter hanging issue seems to be solved! 

I'm however afraid that the build that you're referencing (adapter-annotations) 
is the wrong one: This is a module that is used to generate the 
SLING-INF/adapters.json file inside the bundle. 

> AdapterMethods annotation and adapter proxy service
> ---------------------------------------------------
>
>                 Key: SLING-2938
>                 URL: https://issues.apache.org/jira/browse/SLING-2938
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine, Extensions
>    Affects Versions: Adapter 2.1.0
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've 
> been working on an @AdapterMethod annotation that makes it easier to create 
> Sling adapters, as in
>   @Component
>   @Service
>   public class MyAdapters implements AdapterMethodProvider {
>     @AdapterMethod
>     public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
>   }
> As this requires changes to the sling.api bundle, I'll commit to my 
> whiteboard first, for review



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to