http://bugzilla.spamassassin.org/show_bug.cgi?id=3825
------- Additional Comments From [EMAIL PROTECTED] 2004-09-27 18:35 -------
Subject: Re: Unescaped '#' in rawbody causes havoc
> I think it would be better if we did not allow end-of-line comments and
> required all comments to match:
>
> /^\s*#/
I don't like that much at all. It would break a lot of current rules and
change the rule syntax with no warning.
There are occasional valid reasons to use an end-of-line comment. The most
notable place I use them is when I have a rule that is intentionally
case-sensitive, but it is not at all obvious that I just didn't forget the
/i on the end. I put a comment to indicate that, right there where the
person will be when they decide I made a mistake and break the rule with the
/i.
One could argue that this could be put in a line preceding the rule. I'd
argue that by the time someone is analyzing a rule, they have forgotten all
about preceding descriptive comments, if they bothered to read them in the
first place.
> Then comments don't need to be escaped. I think that would involve less
> surprise and also solves the problem. I don't think this is purely a
> documentation problem.
I think I' be a lot happier with a more complex rule for rule extraction:
s/^(\w+\s+\w+\s+m?(.)[^\2]+\2)/\1/
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
