http://bugzilla.spamassassin.org/show_bug.cgi?id=3776





------- Additional Comments From [EMAIL PROTECTED]  2004-10-13 10:25 -------
Created an attachment (id=2448)
 --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2448&action=view)
alternative patch

FWIW, here's *another* alternative patch for the same issue. This avoids
copying the string multiple times, which could chew RAM for large messages, by
passing a ref to the string, and by truncating it further up the call stack (in
Mail/SpamAssassin/Message/Metadata).

This way, the string won't get copied between its assembly and the split() call
in create_lm().

As a bonus, it also removes the use of $_ in create_lm, since $_ is slower than
a "my" var; and it inlines the $non_word_characters regexp into the split call,
as that will then only be compiled once rather than once per split() call.  So
it should be faster, too.

I think I prefer this one ;)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to