On Friday 11 February 2005 20:06 CET Daniel Quinlan wrote:
> "Malte S. Stretz" <[EMAIL PROTECTED]> writes:
> > *sigh* That commit is still wrong. Why don't you reply to the thread
> > on the list first?
>
> Because nothing was happening and most of the symlink code was too
> complicated and unnecessary. I wanted to get the code *working* and it
> definitively works better now. The symbolic link was never installed
> for the code that was there prior to my commits last night.
There was a discussion going on on this mailinglist on which you could have
asked if that what you committed would work. Which also included a
suggestion by me to split out the reporting stuff which would need a
spamassassin script (instead of a symlink) anyway.
> Benefits of the current code:
>
> - the symbolic link only needs to be installed; it does not need to
> be put under trunk/blib or at trunk/spamassassin
Right, as long as we don't want to test the spamassassin script/symlink.
I'm not opposed to your approach, it didn't come to my mind, but if you had
asked I could have told you a few cases where it doesn't work as you
implemented it.
> - it fixed the problem of spamassassin being installed under man3
> (Makefile assumes that files ending in .pod are man3, it is much
> easier and okay to just remove the .pod extension)
Cool.
> - it works for both vendor and site installs (perhaps there is a
> better way to *simply* determine the script installation directory,
> but I could not find it)
No, it doesn't work for vendor installs, just for perl and site. That's
what all the I_FOO and B_FOO hackery in the Makefile.PL is for.
> - it will work on systems that do not support symlink
But it won't work on systems where the single quote is not supported. On
the quoting of the dollar sign is also different on the platforms. That's
the reason why I moved the logic into a separate script. (I think EU::MM
has a function oneliner() for the correct quoting but I faintly remember
some bug in there.)
> - it employs much less hackery than before
Yeah, cool.
Cheers,
Malte
--
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
<http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
<http://www.catb.org/~esr/faqs/smart-questions.html>
