http://bugzilla.spamassassin.org/show_bug.cgi?id=3997
------- Additional Comments From [EMAIL PROTECTED] 2005-04-12 21:38 -------
Theo, I had to look carefully for that too. That's taken care of in
+sub new_dns_packet {
+ my ($host, $type, $class) = @_;
+
+ # increment our counter, and ensure it stays in range
+ $DNS_ID_COUNTER = (($DNS_ID_COUNTER+1) & 0xffff);
Justin, I didn't see where you stick $DNS_ID_COUNTER on the pending list along
with the socket object and then check the value when you read or bgread... Oh,
that's what you menat in your comment about only having checked in half the
solution :-)
Jonathan, I was concerned that separate processes starting their counters at 0
would make it likely for there to be collisions between counter values, and
starting their counters at a random number leaves a 1 in 65k chance of
collision. But with the port varying too, I think we've gone way past my
estimate of one error per billion messages, so I agree not to worry about it. I
think Justin's use of the PID to hash into a 16 bit number used as an initial
value of a counter that is incremented with each packet send is going to be
fine. (Once he writes the read part of it :-) )
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
