Justin Mason wrote:
Daryl C. W. O'Shea writes:
It also barfs on .* (anything without delimiters). The regexp has to have delimiters as they are required to do the actual test later.

ok -- that's not the case for other inputs to that method. I'd add a test for a delimiter being present in the specific caller that requires them -- or an additional argument specifying whether they should be required in the is_regexp_valid() test.

Fair enough. Once make test finishes I'll commit a fix (I really need to buy a math coprocessor for my 486! ;).


Daryl



Reply via email to