From: Justin Mason [mailto:[EMAIL PROTECTED]
Sent: Wed 7/13/2005 11:59 AM
To: Theo Van Dinter
Cc: [email protected]
Subject: Re: VOTE: make t/ C-T-R for minor changes
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Theo
Van Dinter writes:
> On Wed, Jul 13, 2005 at 11:09:40AM -0700, Justin
Mason wrote:
> > "masses" is currently under C-T-R for minor
changes. I propose that
> > we do the same for "t", too, since
bug 4480 is an example of a trivial
> > t change that fixes a
release-breaking bug, and I'm sure there'll
> > be
more.
>
> masses is fine with me, since users won't actually be
impacted by any changes
> there. t is a little different, though not
as critical as the rest of the
> code/rules/etc.
>
> Basically
what I'm thinking is that small changes are fine, but large/complex
>
changes are not. We really ought to be doing "make test" and such
before
> tagging a release and such, btw, so we don't have
"release-breaking" t bugs.
FWIW, I did ;)
The problem is that
"meta.t" has some unusual dependencies on
parse-rules-for-masses (which it
really shouldn't have), which means that
it may be silently skipped, or run,
depending on platform, and whether
Storable is installed or not.
So whereas it passed on my dev machine, it
failed on one of the
buildbots. messy.
- --j.
-----BEGIN PGP
SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh
CVS
iD8DBQFC1WSmMJF5cimLx9ARAliEAJ41E4S11wyORkpaQJnmG7c68segLACgj9xJ
ERiIQeoraXVfvT++SxC4xNQ=
=aRL+
-----END
PGP SIGNATURE-----
