Warren Togami wrote: > Michael Parker wrote: > >> Howdy, >> >> Just wanted to float this idea. With the help of Matthew Schumacher >> I've worked up a patch for BayesSQL that results in a fairly large speed >> boost for the SQL based configurations. I'm still running baseline and >> new code benchmarks, but rough estimates put the speedup in the >> neighborhood of 2x for MySQL and 4x for PostgreSQL. >> >> The problem is that it involves some changes to _put_tokens, which is >> the most called method in the BayesSQL code and adding an API method to >> the BayesStore API. Obviously not something to be taken lightly. > > > Does this break software using spamassassin's 3.0 API? > > Does any 3rd party software use these particular functions? >
No, it is ADDING an API call. Although I do notice a typo, it's changing _put_token not _put_tokens (this is a new one). I was less concerned with 3rd party use issues than I am with changing the underlying code of a method that is called so often (everytime a token is learned or forgotten). We've already added a stored procedure that must be loaded for PostgreSQL users, but this is IMO no big deal because anyone using the code with PostgreSQL now is broken. This removes one procedure and replaces it with another, so in theory, getting this in in 3.1 will make package maintainers life easier down the road. Adding/updating a stored procedure is doable in a package, via script, but a real PITA. Michael
signature.asc
Description: OpenPGP digital signature
