Justin Mason wrote:

BTW while it's generally a good commit and I'm +1, that removes a
*non*-no-op;
-  my $txt = $self->{conf}->{full_tests}->{$rule};
-  $txt ||= $self->{conf}->{full_evals}->{$rule};
-  $txt ||= $self->{conf}->{head_tests}->{$rule};
-  $txt ||= $self->{conf}->{body_tests}->{$rule};

these lines will attempt to provide a fall-back description line, if the
rules file omitted one.  This is pretty vestigial, but I'd like to keep
some kind of code for a default description string (the rule name,
perhaps?).
Those lines will always result in $txt being undefined.

Reply via email to