On Mon, Feb 06, 2006 at 09:40:12AM -0800, Justin Mason wrote: > >1) right now we need to put the sandbox pm files in MANIFEST or else during > > the nightly runs, mkrules won't copy them over to the rules/ directory > > thereby not letting us test sandboxed eval rules. > > ah, yes. mkrules won't copy .pm's unless they are in the MANIFEST. > > >2) the loadplugin line gets generated in the cf files after the rules > > that need it loaded, so the ifplugin requirement fails, and the rules > > aren't actually run. > > And this should be easily fixable ;) > > You're right, both are bugs; any chance of a bugzilla entry and I'll > try to get them fixed RSN?
Sure, I'll open a BZ about #1. I put in a patch for #2 earlier today, which works though I don't like the implementation. :| http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4785 I think I found a third bug btw: 3) mkrules tries to make sure that loadplugin lines go into the same file as ifplugin sections, which won't work if the ifplugin sections span multiple files. I think this is a minor issue since we can just specify by policy that in the sandbox, the plugin rules have to be in a single file. -- Randomly Generated Tagline: "If you're running the latest version of IIS, then you're not vulnerable to this [security hole], but you're vulnerable to something new." - Phil Cox
pgpqSfJMG4STW.pgp
Description: PGP signature
