http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4789
Summary: sa-update lint checks only work for
updates.spamassassin.org
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Tools
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
earlier today, while working on backporting sa-update for 3.1, I found that the
lint checks
(lint_check_dir()) has some issues, so I commented the code out. here's a few
of the problems:
system ("spamassassin --configpath='$dir' --prefspath=/dev/null --lint");
return (($? >> 8) == 0);
where $dir is the temporary holding place for channel files that just got
downloaded.
1) I don't know if this will work everywhere. /dev/null is *NIX only, the
script may or may not be called
"spamassassin", etc.
2) the check assumes that the channel that was downloaded will be all of the
rules in use. this
completely breaks the concept of channels. ie: updates.spamassassin.org, for
3.2 and beyond, is
supposed to be a full distribution of rules. However, for 3.1, and for people
distributing third party
rules, etc, the channel data is only going to be a subset of rules in use. For
instance, when testing 3.1
with a blank update file that I created (ie: no rules) the lint check failed
because:
[14590] warn: config: warning: score set for non-existent rule MPART_ALT_DIFF
[14590] warn: config: warning: score set for non-existent rule RCVD_IN_MAPS_DUL
[14590] warn: config: warning: score set for non-existent rule RCVD_IN_MAPS_RBL
[14590] warn: config: warning: score set for non-existent rule
RCVD_IN_BL_SPAMCOP_NET
[14590] warn: config: warning: score set for non-existent rule RCVD_IN_MAPS_RSS
[14590] warn: config: warning: score set for non-existent rule RCVD_IN_MAPS_NML
which are scores set in my local.cf. at a minimum we need to ignore all config
files except the temp set
in question.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
