On Tue, Feb 14, 2006 at 05:47:39PM -0500, Daryl C. W. O'Shea wrote: > Using lint_warn() and return $INVALID_VALUE (or $MISSING_REQUIRED_VALUE) > like the existing code did results in double the number of actual lint > errors.
True. My last message was a little off, btw (sorry). We used to just
do info("message") and then the return value which would be 1 lint error
plus some informative text (info is a higher log level than debug, but
neither goto stderr/log by default). Calling lint_warn() is something
which seems to have been added in for the normalize_charset code, which
it shouldn't be doing either for the same reason (it also confused me
leading to my previous mail about using it). In looking at the code
some more, lint_warn() is a Conf::Parser routine which should probably
be private IMO.
> I guess if we want the warnings to go to STDERR (or the log facility
> when daemonized) even when NOT linting, the value returned could be
> decided upon based on whether we're linting or not.
Just throw an info() and return an error.
> Or we can drop the lint_warn()s and go with the generic error messages.
+1 :)
--
Randomly Generated Tagline:
To err is human,
To purr feline.
-- Robert Byrne
pgpv4gSe36af2.pgp
Description: PGP signature
