http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4793





------- Additional Comments From [EMAIL PROTECTED]  2006-02-15 00:44 -------
(In reply to comment #5)
> I would argue that "\W_SOMETHING_\W" is a tag, and "\w_SOMETHING_" 
> or "_SOMETHING_\w" is not a tag.

Perhaps /\b_[^_]+_\b/, but \W is a character, so a header of "_SOMETHING_" 
wouldn't be considered a 
valid tag.  But then we're also trading one limitation for another -- if 
someone wants to do 
"CUSTOMER_CONTACTADDRESS_" for instance (so that in the report people would be 
directed to send 
mail to a customer-specific address), why should we disallow that?  I'd rather 
do:

- add documentation that "_SOMETHING_" in places like the report, add_header, 
replace_header, etc, 
will be considered a tag and replaced, even in the middle of a string such as 
"FOO_SOMETHING_BAR".

- possibly, somehow rewrite _replace_tags() with a version that if the tag 
named "SOMETHING" isn't 
valid and an error is returned we'll leave the text alone.  right now invalid 
tags get replaced with the 
blank string so that all tags are replaced with something.  this doesn't seem 
to documented either btw.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to