On Wed, Mar 08, 2006 at 12:31:57PM +0000, Justin Mason wrote: > - (c) If something is implemented in a plugin, it is *not* a code-tied > rule, that just makes no sense.
Sure it does, you say as much below, but it depends on the situation. > I would define the following criteria to determine if a rule is code-tied > or not: > > - 1. implementation is an "eval:" function > > - 2. the eval function in question is not a documented public API, for use > in more than one rule. Just to finish my statement from above, there are a bunch of plugins which meet these criteria to be considered "code-tied": Razor, Pyzor, DCC, Whitelist SPF, DomainKeys, etc. So it makes sense, depending on the situation. We both were talking about different situations where we're both right in our own little space. Anyway, I haven't fully thought through whether or not the above criteria are sufficient, but for now let's say they are. There are still a few issues that come to mind: 1) any rules implemented by a plugin need to be wrapped in ifplugin/endif conditionals. this usually isn't a problem, but need to keep it in mind. 2) any rules not implemented by a plugin, which aren't of a type that have been around for a long time (let's say since 3.0.0) need to be wrapped in "if version"/endif conditionals. right now I think we just put them in the rules/ dir, which may be sufficient, but onto #3. 3) rule updates/auto activation/promotion/score generation needs to be modified to deal with multiple versions of the engine. otherwise there's no point in having separate rulesrc/rules, etc. at the moment, the automatic stuff only helps for the development version. with "if version" we can probably do multiple versions, but score generation will still be difficult -- perhaps we'll have to do it manually through many "if version" sections. also, we'll probably need to remove "require_version" from all of the configs. > If the term "code-tied" causes confusion, let's make it clearer. > "non-public eval rules"? Sure. -- Randomly Generated Tagline: I am Quayle of Borg....potatoe is irrelevant
pgpYhVomwoMj2.pgp
Description: PGP signature
