Daryl C. W. O'Shea writes:
> Theo Van Dinter wrote:
> > On Thu, Mar 23, 2006 at 01:52:56AM -0500, Daryl C. W. O'Shea wrote:
> >> Why do we have Logger.pm converting spaces to underscores?  This seems 
> >> to be causing nothing but confusion of users.
> > 
> > fwiw, it's not spaces:
> > 
> >     $line =~ s/[\x00-\x1f]/_/gm; # replace control characters with "_"
> > 
> > tab ('\t') is in that range.
> 
> Ah, I didn't look.  I just recalled Michael mentioning it last week or so.
> 
> 
> > how about we do something like this instead:
> > 
> > $line =~ tr/\x09\x20\x00-\x1f/  _/s;
> > 
> > it'll replace multiple tabs and spaces with a single space, and the
> > other control chars with an underscore.
> 
> Sounds good (a lot better) to me.  Something for 3.1.2.

+1

--j.

Reply via email to