http://issues.apache.org/SpamAssassin/show_bug.cgi?id=3109
------- Additional Comments From [EMAIL PROTECTED] 2006-07-19 09:54 -------
> > Here is a new, less-intrusive short-circuiting patch against trunk. It
> > moves the implementation to a plugin,
>
> YAY!!!!
good to hear ;)
> > Mail::SpamAssassin::Plugin::Shortcircuit, which implements the s/c logic.
> > This is made possible with a new plugin API and a flag-setting API on the
> > PerMsgStatus object.
>
> Why not pass all the other available values into handle_hit?
I should have mentioned that. To be honest, I consider those ($area and $desc)
to be legacy -- something that we shouldn't be passing around anyway, and I'd
prefer to get rid of them from that arg list sometime soon if poss. Given
that, I didn't want to bake them into a new plugin API.
> > It is still necessary to dot the PerMsgStatus code with calls like:
> >
> > return if (exists $self->{shortcircuit_flag});
>
> Why not make this into some sort of plugin call?
I was considering it, but wasn't sure about the performance impact of making
the calls through the plugin infrastructure vs calling exists on a member var.
Let me look into that....
> > I can't see a way to do it efficiently otherwise, unfortunately. Other
> > than that, though, the logic is all now in a plugin; in particular,
> > deciding *when* that flag is set all takes place there.
>
> I think that the changes are too specific, and I'd like to make it even more
> generic. It would be easy to give this lots more love with a Check.pm plugin
> BTW :)
Bring it on, I'm dying to see this plugin ;)
what do you mean by 'the changes are too specific' btw? this new set of
changes to PerMsgStatus? suggestions would be welcome, I'm happy to
compromise.
> Also, I strongly, in the -1 veto type of disagreement, with having
> shortcircuit turned on by default.
OK, I can go for that.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
