[EMAIL PROTECTED] wrote: > Modified: > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm > URL: > http://svn.apache.org/viewvc/spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm?view=diff&rev=475485&r1=475484&r2=475485 > ============================================================================== > --- > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm > (original) > +++ > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm > Wed Nov 15 15:15:00 2006 > @@ -139,7 +139,7 @@ > > # dbg("zoom: base found for $rulename: $line"); > > - my $fn = 'Mail::SpamAssassin::PerMsgStatus::'. > + my $fn = 'Mail::SpamAssassin::Plugin::Check::'. > $rulename.'_one_line_body_test'; > > # run the real regexp -- on this line alone. > > Modified: > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/Rule2XSBody.pm > URL: > http://svn.apache.org/viewvc/spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/Rule2XSBody.pm?view=diff&rev=475485&r1=475484&r2=475485 > ============================================================================== > --- > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/Rule2XSBody.pm > (original) > +++ > spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin/Rule2XSBody.pm > Wed Nov 15 15:15:00 2006 > @@ -175,7 +175,7 @@ > # dbg("zoom: base found for $rulename: $line"); > # } > > - my $fn = 'Mail::SpamAssassin::PerMsgStatus::'. > + my $fn = 'Mail::SpamAssassin::Plugin::Check::'. > $rulename.'_one_line_body_test'; >
Ugh, hardcoded package names. You'll notice that I did away with hardcoded package names in the Check.pm rules functions. This means that it can be easily subclassed and just work. Not sure what the best solution for this case is but lets try to avoid hardcoded stuffs. Michael
