http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5148
------- Additional Comments From [EMAIL PROTECTED] 2006-12-05 10:16 ------- Neither patch should consume more time. They are both designed to accomodate the situation where you have two servers listed in ~/.pyzor/servers. The pyzor software will try to contact both servers regardless. No, the pyzor servers are not sync'd at this point, although there is some working going on to do that (see pyzor-users list discussions in the past few months). Once that is in place, it reduces the need for having more than one server in your pyzor config. In the mean time, this patch is useful, particularly since the "official" server retrieved via 'pyzor discover' is not reliable. The timeouts when talking to that server are probably the main reason pyzor is, "time-consuming". You can lower that timeout in the pyzor config (I have done so since it almost always seems to respond within a second or two or not at all - the five second default is probably too high). So to address the "sum vs. max (or even avg)" behavior of the patch... I don't think it matters in terms of time. Summing makes the most sense if most people are reporting to only one server. Max or averaging would make the most sense if most people are reporting to all servers. At this point, I would think that we should start out summing. Then as more people report to N servers, switch to max or avg. Or make it configurable (probably not worth the effort). Of course, it's hard to tell if most people are reporting to just one server or not. However, with the current implementation in SA, if you report to more than one, SA gets confused. So, I would guess that for most SA users, they either use one server or never get scores from pyzor. So assuming that most SA users use one pyzor server would be the safe bet for now. And that's why, if I had to choose, I would pick the summing method at this time (and maybe put some explanatory comments in the code). It shouldn't affect whether pyzor takes more time or not. But you may want to lower the default timeout for pyzor. As I said above, 2 seconds is probably fine, but that's subjective - I haven't run a scientific test. If you want a better patch (comments, lower default timeout) and don't want to do much work beyond review/commit, let me know. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
