argh, Fred, you're right -- those do need to be 'ifplugin'd.
Could you open a bug?

--j.

Fred Tarasevicius writes:
> Hello Justin,
> SpamAssassin version 3.2.0-pre2-r512851
> I'm having problems with sa-update and the 3.2.0 pre2 release.  In the
> distro 50_scores.cf we have scores set for various DC_* rules 4 of
> them I can see,
> DC_PNG_UNO_LARGO
> DC_IMAGE_SPAM_TEXT
> DC_GIF_UNO_LARGO
> DC_IMAGE_SPAM_HTML
> I think these rules should be wrapped in if-plugin lines, I am getting a
> failed lint when trying to install from this pre2 file.  Since I can't
> lint the installed code, I also can't lint when trying to run
> sa-update.
> 
> Once I comment out those scores, I can lint again.
> 
> When I try to run sa-update -D --allowplugins I get the
> following:
> 
> [5535] dbg: rules: meta test DIGEST_MULTIPLE has undefined dependency 
> 'RAZOR2_CHECK'
> [5535] dbg: rules: meta test DIGEST_MULTIPLE has undefined dependency 
> 'DCC_CHECK'
> [5535] dbg: rules: meta test DIGEST_MULTIPLE has undefined dependency 
> 'PYZOR_CHECK'
> [5535] dbg: rules: meta test STOCK_IMG_HTML has undefined dependency 
> '__HTML_IMG_ONLY'
> [5535] dbg: rules: meta test STOCK_IMG_CTYPE has undefined dependency 
> '__HTML_IMG_ONLY'
> [5535] info: rules: meta test HS_PHARMA_1 has dependency 
> 'HS_SUBJ_ONLINE_PHARMACEUTICAL' with a zero score
> [5535] dbg: rules: meta test STOCK_IMG_HDR_FROM has undefined dependency 
> '__HTML_IMG_ONLY'
> [5535] dbg: check: is spam? score=4.205 required=5
> [5535] dbg: check: 
> tests=MISSING_DATE,MISSING_HEADERS,MISSING_SUBJECT,NO_RECEIVED,NO_RELAYS
> [5535] dbg: check: 
> subtests=__HAS_MSGID,__MISSING_REF,__MSGID_OK_DIGITS,__MSGID_OK_HOST,__MSOE_MID_WRONG_CASE,__NONEMPTY_BODY,__SANE_MSGID,__UNUSABLE_MSGID
> [5535] dbg: plugin: Mail::SpamAssassin::Plugin::MIMEHeader=HASH(0x9df068c) 
> implements 'finish_tests', priority 0
> [5535] dbg: plugin: Mail::SpamAssassin::Plugin::Check=HASH(0x9df07a0) 
> implements 'finish_tests', priority 0
> channel: lint check of update failed, channel failed
> ...
> [5535] dbg: diag: updates complete, exiting with code 4
> 
> 
> 
> Digging into this I found DIGEST_MULTIPLE is also not wrapped around
> if-plugin lines, should it be?  I do not use RAZOR2, DCC, or PYZOR
> so these tests are not active for me.  The issue above with
> __HTML_IMG_ONLY is most likely because those rules are wrapped inside
> the block for ImageInfo plugin and I don't recall enabling it.
> 
> 
> 
> 
> Wednesday, February 28, 2007, 12:28:09 PM, you wrote:
> 
> > hey committers / PMC members --
> 
> > please gimme your votes on these prerelease tarballs:
> 
> >  
> > http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.tar.bz2
> >  
> > http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.tar.gz
> >   http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.zip
> 
> > Here's the proposed announce mail.  There's no "release highlights/
> > changes" (yet), but that shouldn't stop the tarballs!  Once we have
> > 3 votes, I'll post the announcement.
> 
> > -----------------------------------------------------------------------
> > To: users, dev
> > Subject: NOTICE: SpamAssassin 3.2.0-pre2 PRERELEASE available
> >  
> > SpamAssassin 3.2.0-pre2 is released!
> > This is a *prerelease* of SpamAssassin 3.2.0; not the full release.
> 
> > SpamAssassin is a mail filter which uses advanced statistical and
> > heuristic tests to identify spam (also known as unsolicited bulk email).
> 
> > Highlights of the release
> > -------------------------
> 
> > (TODO ;)
> 
> > Downloading
> > -----------
> 
> >  
> > http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.tar.bz2
> >  
> > http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.tar.gz
> >   http://people.apache.org/~jm/devel/Mail-SpamAssassin-3.2.0-pre2.zip
> 
> > md5sum of archive files:
> 
> >   b530e3b3b828cc0fbe8ee738a300dcef 
> > Mail-SpamAssassin-3.2.0-pre2.tar.bz2
> >   5c84180b188f2dde9bb6ff5e11bf35e6 
> > Mail-SpamAssassin-3.2.0-pre2.tar.gz
> >   9b5d4a335b18ef49103e81e04df1df4e  Mail-SpamAssassin-3.2.0-pre2.zip
> 
> > sha1sum of archive files:
> 
> >   99080918fe4d194923a672443c49a14473310b34 
> > Mail-SpamAssassin-3.2.0-pre2.tar.bz2
> >   9878e61bd3f9fc90903ac5840b5dd61cffe94400 
> > Mail-SpamAssassin-3.2.0-pre2.tar.gz
> >   f65c4bf5ea09d5e887bef0ca1d851d1ad8b45698  Mail-SpamAssassin-3.2.0-pre2.zip
> 
> > The release files also have a .asc accompanying them.  The file serves
> > as an external GPG signature for the given release file.  The signing
> > key is available via the wwwkeys.pgp.net key server, as well as
> > http://spamassassin.apache.org/released/GPG-SIGNING-KEY
> 
> > The key information is:
> 
> > pub  1024D/265FA05B 2003-06-09 SpamAssassin Signing Key <[EMAIL PROTECTED]>
> >      Key fingerprint =3D 26C9 00A4 6DD4 0CD5 AD24  F6D7 DEE0 1987 265F A05B
> 
> > Important installation notes
> > ----------------------------
> 
> > - see the INSTALL and UPGRADE files in the distribution.
> 
> > Summary of major changes since 3.1.x
> > ------------------------------------
> 
> > (TODO ;)
> 
> 
> -- 
> Best regards,
>  Fred                            mailto:[EMAIL PROTECTED]

Reply via email to