We need an (SVN-only) .t test case that tests mass-check; it's pretty vital during dev time.
Mark -- a trivial test for mass-check: $ cd masses $ ./mass-check -n -o ham:dir:. Undefined subroutine &Mail::SpamAssassin::Conf::Parser::untaint_var called at /home/jm/ftp/sa/trunk/masses/../blib/lib/Mail/SpamAssassin/Conf/Parser.pm line 617. --j. Daryl C. W. O'Shea writes: > Mark Martinec wrote: > > On Saturday September 15 2007 11:12:42 Daryl C. W. O'Shea wrote: > >> Crap, I was looking forward to having this week's --net results for > >> scoring. > >> > >> Undefined subroutine &Mail::SpamAssassin::Conf::Parser::untaint_var > >> called at > >> /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/C > >> onf/Parser.pm line 617. > > > > Looking into the matter. I wonder why it doesn't fail here > > during 'make test' and during regular use... > > I don't know (try running mass-check, even as a client, with enough > arguments to get it to load and it'll probably happen for you). One of > the mass-check clients also complained about some more (probably due to > the same bug): > > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > exported by the Mail::SpamAssassin::Util module > Can't continue after import errors at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/Hashcash.pm > > line 93 > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/Hashcash.pm > > line 93. > Compilation failed in require at (eval 64) line 1. > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > exported by the Mail::SpamAssassin::Util module > Can't continue after import errors at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/AutoWhitelist.pm > > line 51 > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/AutoWhitelist.pm > > line 51. > Compilation failed in require at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/AWL.pm > > line 66. > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/AWL.pm > > line 66. > Compilation failed in require at (eval 73) line 1. > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > exported by the Mail::SpamAssassin::Util module > Can't continue after import errors at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/MIMEHeader.pm > > line 68 > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/MIMEHeader.pm > > line 68. > Compilation failed in require at (eval 78) line 1. > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > exported by the Mail::SpamAssassin::Util module > Can't continue after import errors at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/HTMLEval.pm > > line 27 > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/HTMLEval.pm > > line 27. > Compilation failed in require at (eval 93) line 1. > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > exported by the Mail::SpamAssassin::Util module > Can't continue after import errors at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/MIMEEval.pm > > line 28 > BEGIN failed--compilation aborted at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/MIMEEval.pm > > line 28. > Compilation failed in require at (eval 96) line 1. > > > plugin: eval failed: Undefined subroutine > &Mail::SpamAssassin::Plugin::Check::untaint_var called at > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin/Plugin/Check.pm > > line 905.
