> It needs to be reverted asap.

asap? Is anybody running trunk code under 5.6 ???


> Please test with perl 5.6.1 before committing... 5.6.1 and 5.8.x have
> radically different mechanisms to deal with UTF-8.

$ svn diff
Index: lib/Mail/SpamAssassin/Message/Node.pm
===================================================================
--- lib/Mail/SpamAssassin/Message/Node.pm       (revision 586642)
+++ lib/Mail/SpamAssassin/Message/Node.pm       (working copy)
@@ -43,8 +43,6 @@
 use Mail::SpamAssassin::HTML;
 use Mail::SpamAssassin::Logger;

-use Encode ();
-
 =item new()


$ svn -m 'do not "require" Encode in Node.pm, depend on a Conf module
          to bring it in if expected to be needed' ci
Sending        lib/Mail/SpamAssassin/Message/Node.pm
Transmitting file data .
Committed revision 586730.


This is kinda ugly, but it seems to be a practice in SpamAssassin
to depend on other modules to 'require' of 'use' needed external modules.

  Mark

Reply via email to