http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5680


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ALL_TRUSTED fires even if X-|[review] ALL_TRUSTED fires
                   |Originating-IP is used      |even if X-Originating-IP is
                   |                            |used




------- Additional Comments From [EMAIL PROTECTED]  2007-11-02 11:36 -------
(In reply to comment #4)
> New version as proposed from Justin: Lookup headers like X-Originating-IP too
> in Metadata/Received.pm

ok, that was nearly it -- but I added some tests and found a few failure cases
(in particular if the X-Originating-IP was trusted but a non-192.168 address, it
*wouldn't be added to the list at all*; also trusted/external/internal is not a
single set of cases.

I've checked in a replacement that adds those test cases, and passes them...
it's in SVN trunk:

: jm 14...; svn commit -m "bug 5680: ALL_TRUSTED fires even if X-Originating-IP
appears in headers; add IP addresses from the 'X-Yahoo-Post-IP',
'X-Originating-IP', 'X-Apparently-From', 'X-SenderIP' headers to the relays list
in order to fix this"
Sending        lib/Mail/SpamAssassin/Message/Metadata/Received.pm
Sending        t/trust_path.t
Transmitting file data ..
Committed revision 591423.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to