https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5934
--- Comment #2 from Karsten Bräckelmann <[EMAIL PROTECTED]> 2008-07-02 14:00:56 PST --- (In reply to comment #0) > Created an attachment (id=4344) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4344) [details] > Patch to RelayCountry.pm, adding more metadata > + my @visited = keys %countriesvisited; > + my $visits = $#visited; This probably should be rewritten, since we do not use the @visited list. my $visits = scalar keys %countriesvisited; > + if ($visits++ > 0) { Here we don't need the post increment. Also, I guess we should be consistent WRT whitespace and using the increment operators rather than +=. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
